[3.11] gh-124651: Quote template strings in venv activation scripts (GH-124712) (GH-126185)
#126269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-124712) (pythonGH-126185) (cherry picked from commit d48cc82) (cherry picked from commit 8450b24)
This was referenced Nov 1, 2024
|
@vsajip: Would you mind to review this backport to 3.11? Again, I had conflicts in |
vsajip
approved these changes
Nov 1, 2024
|
@pablogsal: Would you mind to merge/review this 3.11 security fix? |
|
Yup |
|
GH-126300 is a backport of this pull request to the 3.10 branch. |
|
GH-126301 is a backport of this pull request to the 3.9 branch. |
ambv
pushed a commit
that referenced
this pull request
Nov 4, 2024
…GH-124712) (GH-126185) (GH-126269) (GH-126300) (cherry picked from commit ae961ae)
ambv
pushed a commit
that referenced
this pull request
Nov 4, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit d48cc82) (cherry picked from commit 8450b24)
venvactivation scripts do not quote strings properly #124651